Use espree when parsing expressions #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be helpful for typescript users, as fragment parsing is not that fast in @typescript-eslint, and vue syntax does no support types anyway cc @mysticatea |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok after getting more feedback in bug report from person trying to lint Vue + Coffeescript, my understanding is that the issue is really that for all Vue "expressions" (eg template
{{ ... }},v-for, etc), Vue always parses these the same way (as JS)So should always use
espreewhen parsing expressions, not specified custom parserSo closing #61 in favor of this PR